Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing dynamic splices via #${splice} like Scala2-Quill #153

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

deusaquilus
Copy link
Contributor

This is the ProtoQuill equivalent of: zio/zio-quill#1020
It uses a very similar pattern of detecting quote-parts that have a # at the end.
Unlike Scala2-Quill however, the resulting Quote is stored in the runtimeQuotes of the Quoted case class instead of the AST tree. Initially the parser puts into onto the AST tree but then it is extracted and replaced with a QuotationTag (the same as other runtime quotes). This way it fits perfectly into the ProtoQuill compile-time vs runtime paradigm and the ProtoQuill AST is still serializable from the beginning (i.e. from quotation onward vs Scala2-Quill which is not because it stores Dynamic and Lift values directly in the tree).

@deusaquilus deusaquilus merged commit c13f50e into master Jul 11, 2022
@deusaquilus deusaquilus deleted the dynamic_quotes branch July 11, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant