Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slf4j2 bridge #577

Merged
merged 14 commits into from
Jan 24, 2023
Merged

Slf4j2 bridge #577

merged 14 commits into from
Jan 24, 2023

Conversation

justcoon
Copy link
Contributor

@justcoon justcoon commented Nov 27, 2022

Fixes: #567

slf4j bridge for slf4j v2

few notes:

  • new module zio-logging-slf4j2-bridge as zio-logging-slf4j-bridge is for slf4j v1, do we want to change naming for modules? For example have zio-logging-slf4j-bridge for actual version - v2, and for v1 have zio-logging-slf4j1-bridge or something else
  • slf4j v2 using JDK9+ module system (JPMS) see: slf4j v2 changes, this currently introduced few problems, as sbt have unresolved JPMS support:
    • sbt jpms issue: JDK9: Support module-info.java sbt/sbt#3368
    • sbt-jpms plugin prototype
    • in relation to mentioned sbt JPMS issue, following steps were applied:
      • compileOrder := CompileOrder.JavaThenScala setting (mentioned in sbt issue) worked, but in this case java classes, can not use scala classes, code was implemented in that way
      • javacOptions and javaOptions dependencies with --module-path
      • there is issue with scala doc in relation to JPMS module, scala doc artifact publishing is disabled now

@jdegoes
Copy link
Member

jdegoes commented Dec 28, 2022

@justcoon Good to merge when conflicts resolved. 👍

@justcoon justcoon marked this pull request as ready for review January 23, 2023 19:49
@justcoon justcoon requested a review from a team as a code owner January 23, 2023 19:50
@jdegoes jdegoes merged commit d943de3 into zio:master Jan 24, 2023
@justcoon justcoon deleted the slf4j2_bridge branch February 13, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SLF4J 2.0.x for slf4j-bridge
2 participants