Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #981

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Fix CI #981

merged 1 commit into from
Jul 15, 2023

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Jul 15, 2023 •
edited
Loading

The "build" CI step is failing for reasons out of our control

Cc @khajavi

erikvanoosten
erikvanoosten reviewed Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@erikvanoosten erikvanoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this also in #960 which is awaiting a review.

@guizmaii
Copy link
Member Author

I fixed this also in #960 which is awaiting a review.

Would have been better to make a dedicated PR like this one

@guizmaii guizmaii merged commit d5f6e8a into master Jul 15, 2023
16 of 18 checks passed
@guizmaii guizmaii deleted the fix_ci_2 branch July 15, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikvanoosten erikvanoosten erikvanoosten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guizmaii @erikvanoosten