Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client admin #63

Closed
wants to merge 25 commits into from
Closed

Client admin #63

wants to merge 25 commits into from

Conversation

TimPigden
Copy link
Contributor

Added clientAdmin with tests. #62
Also started documentation and rearranged some tests pursuing possible bug (will raise issue)

@iravid
Copy link
Member

iravid commented Nov 16, 2019

@TimPigden Can you rebase this against master?

@TimPigden
Copy link
Contributor Author

sorry I'm confused. I based my changes on these files and they are legitimate updates. I ran rebase master in my branch and it just tells me I'm up-to-date. I did a cosmetic change to force a new upload, but I'm not convinced that's enough. For the conflicting files we need to take the new version from here. Or should I merge my changes into updates master and do a new PR (git is not my speciality!)

@iravid
Copy link
Member

iravid commented Nov 16, 2019 via email

@TimPigden
Copy link
Contributor Author

TimPigden commented Nov 16, 2019 via email

@iravid
Copy link
Member

iravid commented Nov 16, 2019

Is origin pointing to your fork?

@TimPigden
Copy link
Contributor Author

 remote origin
  Fetch URL: https://github.com/TimPigden/zio-kafka.git
  Push  URL: https://github.com/TimPigden/zio-kafka.git
  HEAD branch: master
  Remote branches:
    client-admin    tracked
    feature/streams tracked
    local-compile   tracked
    master          tracked
  Local branches configured for 'git pull':
    client-admin  merges with remote client-admin
    local-compile merges with remote local-compile
    master        merges with remote master
  Local refs configured for 'git push':
    client-admin  pushes to client-admin  (up-to-date)
    local-compile pushes to local-compile (up-to-date)
    master        pushes to master        (up-to-date)

@TimPigden
Copy link
Contributor Author

tim@tim-home2:~/code/zio-kafka$ git remote show upstream
* remote upstream
  Fetch URL: https://github.com/zio/zio-kafka.git
  Push  URL: https://github.com/zio/zio-kafka.git
  HEAD branch: master
  Remote branches:
    feature/streams tracked
    master          tracked
  Local ref configured for 'git push':
    master pushes to master (local out of date)
tim@tim-home2:~/code/zio-kafka$ 

@TimPigden
Copy link
Contributor Author

I've looked for attempted fixes to local out of date but they just say use force - which I've already done. Everything else says "Already up-to-date" .
Shall I just give up and create a new PR?

@iravid
Copy link
Member

iravid commented Nov 16, 2019

@TimPigden You can create a new PR, but you'll still have to merge the changes in master to your branch. Otherwise you'll still have conflicts.

Try doing the following:

git checkout master
git pull upstream master
git checkout client-admin
git rebase master
git push -f

@TapanVaishnav
Copy link

Try doing the following:

shorter version just in case

git fetch upstream
git rebase upstream/master
git push origin client-admin --force

@iravid
Copy link
Member

iravid commented Nov 19, 2019

Superseded by #77

@iravid iravid closed this Nov 19, 2019
@TimPigden TimPigden mentioned this pull request Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants