Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using a Task when code is pure. Prefer to use Try #539

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

guizmaii
Copy link
Member

No description provided.

@guizmaii guizmaii force-pushed the clean_code branch 4 times, most recently from 1bcc2e4 to 3ffc49a Compare November 16, 2022 19:46
@guizmaii guizmaii changed the title Avoid using a Task when code is pure. Prefer to use Try. Avoid using a Task when code is pure. Prefer to use Try Nov 16, 2022
Copy link
Collaborator

@svroonland svroonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall, but a few points

@jdegoes jdegoes merged commit 77de3f2 into zio:master Feb 14, 2023
@guizmaii guizmaii deleted the clean_code branch February 15, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants