Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple subscriptions on the same Consumer #517

Merged
merged 56 commits into from
Feb 27, 2023
Merged

Support for multiple subscriptions on the same Consumer #517

merged 56 commits into from
Feb 27, 2023

Commits on Oct 11, 2022

  1. Draft of multiple subscriptions consumer

    @svroonland
    svroonland committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8d6f74a View commit details
    Browse the repository at this point in the history

  2. Test for failure

    @svroonland
    svroonland committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    cbdb235 View commit details
    Browse the repository at this point in the history

  3. Unsubscribe

    @svroonland
    svroonland committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    65fc9a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Integrate MultiConsumer in Consumer 

    * Remove subscribeAnd / SubscribedConsumer
    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    14396e9 View commit details
    Browse the repository at this point in the history

  2. Ergonomics

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    37722ea View commit details
    Browse the repository at this point in the history

  3. Fix ordering issue

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e76af45 View commit details
    Browse the repository at this point in the history

  4. Remove obsolete test

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    63d3d52 View commit details
    Browse the repository at this point in the history

  5. Use ZStream.fromQueueWithShutdown

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    778535e View commit details
    Browse the repository at this point in the history

  6. Add some docs

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    55e6cbf View commit details
    Browse the repository at this point in the history

  7. Merge specs

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    254030c View commit details
    Browse the repository at this point in the history

  8. Subscription type mixing is not supported

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b6d8eb0 View commit details
    Browse the repository at this point in the history

  9. Scala 2.12 fix

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    d98fe03 View commit details
    Browse the repository at this point in the history

  10. Tweak doc

    @svroonland
    svroonland committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    6e96023 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Reduce exposed interface

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    be794d6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into multiple-subscriptions

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    82034e8 View commit details
    Browse the repository at this point in the history

  3. Update docs

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3b1a062 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    a75a5c2 View commit details
    Browse the repository at this point in the history

  5. Fix formatting

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    adf2f79 View commit details
    Browse the repository at this point in the history

  6. Remove obsolete doc

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    c1484bc View commit details
    Browse the repository at this point in the history

  7. Add docs

    @svroonland
    svroonland committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    931cafa View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Merge remote-tracking branch 'origin/master' into multiple-subscriptions

    @svroonland
    svroonland committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    10cd476 View commit details
    Browse the repository at this point in the history

  2. No queue shutdown

    @svroonland
    svroonland committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b13e546 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Update zio-kafka/src/main/scala/zio/kafka/consumer/InvalidSubscriptio… 

    …nUnion.scala

Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    eac1617 View commit details
    Browse the repository at this point in the history

  2. Update zio-kafka/src/main/scala/zio/kafka/consumer/InvalidSubscriptio… 

    …nUnion.scala

Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    3768a9a View commit details
    Browse the repository at this point in the history

  3. Update zio-kafka/src/main/scala/zio/kafka/consumer/Consumer.scala 

    Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7e33c15 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Merge remote-tracking branch 'origin/master' into multiple-subscriptions

    @svroonland
    svroonland committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b5b1e2a View commit details
    Browse the repository at this point in the history

  2. Handle an exceptional case

    @svroonland
    svroonland committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    aca52eb View commit details
    Browse the repository at this point in the history

  3. Update comment

    @svroonland
    svroonland committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    26b1b7a View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Test for flakyness

    @svroonland
    svroonland committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    2881740 View commit details
    Browse the repository at this point in the history

  2. Undo flaky aspects

    @svroonland
    svroonland committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    f1d42c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Avoid race conditions between polling and (un)subscribing

    @svroonland
    svroonland committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    85378e7 View commit details
    Browse the repository at this point in the history

  2. Remove println

    @svroonland
    svroonland committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7d80363 View commit details
    Browse the repository at this point in the history

  3. Separate spec for Subscriptions

    @svroonland
    svroonland committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    459d31c View commit details
    Browse the repository at this point in the history

  4. Update docs/sharing-consumer.md 

    Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    40fe3c4 View commit details
    Browse the repository at this point in the history

  5. Update docs/sharing-consumer.md 

    Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    df59404 View commit details
    Browse the repository at this point in the history

  6. Update docs/sharing-consumer.md 

    Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    9e8cb73 View commit details
    Browse the repository at this point in the history

  7. Remove bufferSize

    @svroonland
    svroonland committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7a528ae View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @svroonland
    svroonland committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    137764b View commit details
    Browse the repository at this point in the history

  9. Update zio-kafka/src/main/scala/zio/kafka/consumer/Consumer.scala 

    Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8b20c3d View commit details
    Browse the repository at this point in the history

  10. Optimization: Do not deserialize the message if the deserializers are… 

    … `Serde.byteArray` as these deserializers are not doing anything anyway (#654)
    @guizmaii
    guizmaii authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    473f7d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. [POC] Move the ConsumerRebalanceListener creation to the RunLoop (#… 

    …662)
    @guizmaii
    guizmaii authored Feb 24, 2023
    Configuration menu
    Copy the full SHA
    15d659c View commit details
    Browse the repository at this point in the history

  2. Update zio-kafka/src/main/scala/zio/kafka/consumer/internal/Runloop.s… 

    …cala

Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 24, 2023
    Configuration menu
    Copy the full SHA
    69570d6 View commit details
    Browse the repository at this point in the history

  3. Update zio-kafka/src/main/scala/zio/kafka/consumer/internal/Runloop.s… 

    …cala

Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 24, 2023
    Configuration menu
    Copy the full SHA
    beb9876 View commit details
    Browse the repository at this point in the history

  4. Apply same readability pattern as with the other commands (#663)

    @guizmaii
    guizmaii authored Feb 24, 2023
    Configuration menu
    Copy the full SHA
    fc91a91 View commit details
    Browse the repository at this point in the history

  5. Remove magic nr 32

    @svroonland
    svroonland committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    6777b6d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into multiple-subscriptions

    @svroonland
    svroonland committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5a9fb7e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Throw exception for unexpected case

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    2922d6b View commit details
    Browse the repository at this point in the history

  2. Document nr 32

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    7b00944 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into multiple-subscriptions

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    42e8682 View commit details
    Browse the repository at this point in the history

  4. Immediately end new requests when shutdown

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    e6fca42 View commit details
    Browse the repository at this point in the history

  5. Make test case fail

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    b391f10 View commit details
    Browse the repository at this point in the history

  6. Restore test case

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    b5f59a2 View commit details
    Browse the repository at this point in the history

  7. Add alternative test case for issue

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    dc3f10e View commit details
    Browse the repository at this point in the history

  8. End requests and partition streams we are no longer subscribed to

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    33ea3f2 View commit details
    Browse the repository at this point in the history

  9. Fix test case and reduce test duration

    @svroonland
    svroonland committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    74e079e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Update zio-kafka/src/main/scala/zio/kafka/consumer/internal/Runloop.s… 

    …cala

Co-authored-by: Jules Ivanic <[email protected]>
    @svroonland @guizmaii
    svroonland and guizmaii authored Feb 27, 2023
    Configuration menu
    Copy the full SHA
    240d2c6 View commit details
    Browse the repository at this point in the history