Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer org.apache.kafka.clients.admin.Admin over org.apache.kafka.clients.admin.AdminClient as recommended in AdminClient documentation #497

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Prefer org.apache.kafka.clients.admin.Admin over org.apache.kafka.clients.admin.AdminClient as recommended in AdminClient documentation #497

merged 1 commit into from
Sep 28, 2022

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Aug 15, 2022 •
edited
Loading

image

@guizmaii guizmaii requested a review from iravid as a code owner August 15, 2022 20:42
@strokyl
Copy link
Contributor

strokyl commented Sep 23, 2022

Test failure:

 - Consumer Streaming - Consumer.subscribeAnd manual subscription without groupId works properly
Timeout of 5 m exceeded.
Executed in 5 m 16 s

16:30:13.815 [controller-event-thread] INFO  state.change.logger - [Controller id=0 epoch=1] Sending UpdateMetadata request to brokers HashSet() for 0 partitions
[info] Completed tests
[error] Failed tests:
[error] 	zio.kafka.consumer.ConsumerSpec
[error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 352 s (05:52), completed Aug 26, 2022, 4:30:14 PM

Probably flaky no?

@strokyl
Copy link
Contributor

strokyl commented Sep 23, 2022

@iravid is it possible to know if we have any chance to merge that or you have no interest in it?

vigoo
vigoo previously approved these changes Sep 23, 2022
View reviewed changes
@vigoo
Copy link
Contributor

vigoo commented Sep 23, 2022

Please rebase then its good to go

@guizmaii guizmaii force-pushed the use_admin_zio branch 2 times, most recently from 7b8acd1 to 0085ee1 Compare September 28, 2022 09:27
@guizmaii
Prefer org.apache.kafka.clients.admin.Admin over `org.apache.kafka.…
8181b52 
…clients.admin.AdminClient` as recommended in `AdminClient` documentation
@guizmaii
Copy link
Member Author

@vigoo Just rebased my PR :)

@vigoo vigoo merged commit cc0c620 into zio:master Sep 28, 2022
@vigoo
Copy link
Contributor

vigoo commented Sep 28, 2022

thanks!

@guizmaii guizmaii deleted the use_admin_zio branch January 11, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo approved these changes

@iravid iravid Awaiting requested review from iravid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guizmaii @strokyl @vigoo