High-level API for consuming messages with an effect #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Sep 25, 2019
| .aggregate(ZSink.foldLeft[Offset, OffsetBatch](OffsetBatch.empty)(_ merge _)) | ||
| .mapM(_.commit) | ||
| .tap(_ => putStrLn(s"Commit done")) | ||
| .run(ZSink.drain) |
There was a problem hiding this comment.
Suggested change
| .run(ZSink.drain) | |
| .runDrain |
| } | ||
| .aggregate(ZSink.foldLeft[Offset, OffsetBatch](OffsetBatch.empty)(_ merge _)) | ||
| .mapM(_.commit) | ||
| .tap(_ => putStrLn(s"Commit done")) |
| def consumeM[R, K: Serde, V: Serde]( | ||
| subscription: Subscription, | ||
| settings: ConsumerSettings | ||
| )(f: (K, V) => ZIO[R, Nothing, Unit]): ZIO[R with Clock with Blocking with Console, Throwable, Unit] = |
There was a problem hiding this comment.
Suggested change
| )(f: (K, V) => ZIO[R, Nothing, Unit]): ZIO[R with Clock with Blocking with Console, Throwable, Unit] = | |
| )(f: (K, V) => ZIO[R, Nothing, Unit]): ZIO[R with Clock with Blocking, Throwable, Unit] = |
| * The effect should must absorb any failures. Failures should be handled by retries or ignoring the | ||
| * error, which will result in the Kafka message being skipped. | ||
| * | ||
| * Usage example: |
| * @tparam V Type of values (an implicit [[Serde]] should be in scope) | ||
| * @return Effect that completes with a unit value only when interrupted. May fail when the [[Consumer]] fails. | ||
| */ | ||
| def consumeM[R, K: Serde, V: Serde]( |
There was a problem hiding this comment.
We don't have a version of this that takes a (K, V) => Unit, and we probably won't have. So let's call this consumeWith.
| .flatMap { _ => | ||
| consumer.partitioned | ||
| .flatMapPar(Int.MaxValue, outputBuffer = settings.perPartitionChunkPrefetch) { | ||
| case (partition @ _, partitionStream) => |
There was a problem hiding this comment.
Suggested change
| case (partition @ _, partitionStream) => | |
| case (_, partitionStream) => |
svroonland
commented
Sep 25, 2019
| * @tparam V Type of values (an implicit [[Serde]] should be in scope) | ||
| * @return Effect that completes with a unit value only when interrupted. May fail when the [[Consumer]] fails. | ||
| */ | ||
| def consumeM[R, K: Serde, V: Serde]( |
There was a problem hiding this comment.
I'm not happy about the R type parameter here, but since K and V need to be specified, I don't see how to get rid of R.
There was a problem hiding this comment.
Well, the consuming function could require any R, so it is more correct to be polymorphic in the dependencies used (in addition to Blocking and Clock).
|
Ok, let's just add a test and this should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See docs. This provides a very easy, high-level API to apply an effect to each message, while benefitting from parallelism and automatic committing after processing.