Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent users from enabling auto commit #1290

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Prevent users from enabling auto commit #1290

merged 3 commits into from
Jul 24, 2024

Commits on Jul 22, 2024

  1. Prevent users from enabling auto commit 

    Zio-kafka applications get their performance from pre-fetching data. When auto commit is enabled, the consumer will automatically commit batches _before_ they are processed by the user streams.

An unaware user might accidentally enable auto commit and lose data during rebalances.

Solves #1289.
    @erikvanoosten
    erikvanoosten committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f065e38 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @erikvanoosten
    erikvanoosten committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8dc16f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Add warning for fromJavaConsumer

    @erikvanoosten
    erikvanoosten committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5e5ca7c View commit details
    Browse the repository at this point in the history