Producer alternative send chunk #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, i'd highly appreciate that!!
Dominik Dorn
https://dominikdorn.com/ | https://twitter.com/domdorn
XING: https://www.xing.com/profile/Dominik_Dorn
LINKEDIN: https://www.linkedin.com/in/dominik-dorn/
…On Tue, Jul 16 2024 at 19:05, Erik van Oosten < ***@***.*** > wrote:
@domdorn ( https://github.com/domdorn ) Nice idea! This will work
definitely better than the proposal in #1283 (
#1283 ). Is it okay if I take this
and work it out further?
—
Reply to this email directly, view it on GitHub (
#1284 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AAAYP7P5MLFRIUNMWI2JJMDZMVHHNAVCNFSM6AAAAABK624K56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGQYTKNJRGY
).
You are receiving this because you were mentioned. Message ID: <zio/zio-kafka/pull/1284/c2231415516
@ github. com>
|
|
|
Oops, again sorry. That comment doesn't apply to your code but a refactoring I did 😊.
|
domdorn
force-pushed
the
producer_alternative_sendChunk
branch
from
136aed2
to
2752d1e
Compare
domdorn
force-pushed
the
producer_alternative_sendChunk
branch
from
2752d1e
to
62f5689
Compare
|
closed in favour of #1286 (although I liked my ZIO.async stuff..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for discussion: alternative implementation of the sendChunk method..