Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A lost partition is no longer fatal #1252

Merged
merged 7 commits into from
Jul 9, 2024
Merged

A lost partition is no longer fatal #1252

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ed3a67
A lost partition is no longer fatal
erikvanoosten Jun 10, 2024
605f536
typo
erikvanoosten Jun 10, 2024
ff8e92d
Add logging
erikvanoosten Jun 11, 2024
dcf61c2
Merge branch 'master' into lost
erikvanoosten Jun 11, 2024
736c7ed
Merge branch 'master' into lost
erikvanoosten Jun 11, 2024
e52e19e
Merge branch 'master' into lost
erikvanoosten Jun 12, 2024
cf3516d
Merge branch 'master' into lost
erikvanoosten Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions zio-kafka/src/main/scala/zio/kafka/consumer/internal/PartitionStreamControl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ final class PartitionStreamControl private (
private[internal] def maxPollIntervalExceeded(now: NanoTime): UIO[Boolean] =
queueInfoRef.get.map(_.deadlineExceeded(now))

/** To be invoked when the partition was lost. */
private[internal] def lost: UIO[Boolean] = {
val lostException = new RuntimeException(s"Partition ${tp.toString} was lost") with NoStackTrace
interruptionPromise.fail(lostException)
}

/** To be invoked when the stream is no longer processing. */
private[internal] def halt: UIO[Boolean] = {
val timeOutMessage = s"No records were polled for more than $maxPollInterval for topic partition $tp. " +
Expand All @@ -97,6 +91,14 @@ final class PartitionStreamControl private (
interruptionPromise.fail(consumeTimeout)
}

/** To be invoked when the partition was lost. It clears the queue and ends the stream. */
private[internal] def lost: UIO[Unit] =
logAnnotate {
ZIO.logDebug(s"Partition ${tp.toString} lost") *>
erikvanoosten marked this conversation as resolved.
Show resolved Hide resolved
dataQueue.takeAll *>
dataQueue.offer(Take.end).unit
}

/** To be invoked when the partition was revoked or otherwise needs to be ended. */
private[internal] def end: ZIO[Any, Nothing, Unit] =
logAnnotate {
Expand Down
Loading