Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests faster #1139

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Make tests faster #1139

merged 2 commits into from
Dec 22, 2023

Conversation

erikvanoosten
Copy link
Collaborator

@erikvanoosten erikvanoosten commented Dec 17, 2023

Make tests faster

Make tests faster by

  • running them in parallel
  • reduce number of runs with nonFlaky

Results for sbt test:

  • on GHA: from 17m 34s to 7m
  • on my laptop: from 231s to 87s

Also: upgrade logback from 1.3.14 to 1.4.14.

@erikvanoosten erikvanoosten marked this pull request as ready for review December 17, 2023 14:52
@erikvanoosten erikvanoosten changed the title Make tests faster, enable test for cooperative assignor Make tests faster Dec 22, 2023
Make tests faster by
 - running them in parallel
 - reduce number of runs with `nonFlaky`

This more than halves the run time of `sbt test` (231 to 87s on my machine).

Also: upgrade logback from 1.3.14 to 1.4.14.
@erikvanoosten
Copy link
Collaborator Author

Sorry for the force push. I squashed all the commits to make rebasing easier.

@erikvanoosten
Copy link
Collaborator Author

erikvanoosten commented Dec 22, 2023

Instead of removing the nonFlaky annotations, in the last commit only the number of retries is reduced. The test are still substantially faster 😀.

@erikvanoosten erikvanoosten merged commit 8a31ed7 into master Dec 22, 2023
3 of 10 checks passed
@erikvanoosten erikvanoosten deleted the faster-tests branch December 22, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants