Make maxRebalanceDuration configurable #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svroonland
reviewed
Nov 29, 2023
| @@ -29,6 +29,7 @@ final case class ConsumerSettings( | |||
| rebalanceListener: RebalanceListener = RebalanceListener.noop, | |||
| restartStreamOnRebalancing: Boolean = false, | |||
| rebalanceSafeCommits: Boolean = false, | |||
| maxRebalanceDuration: Option[Duration] = None, | |||
There was a problem hiding this comment.
Why not have the default duration here?
There was a problem hiding this comment.
Because the default depends on maxPollInterval for which the default is fetched in RunloopAccess.
There are other options:
- store a function in ConsumerSettings (maxPollInterval => maxBalanceDuration)
fetch the defaultdoesn't work, it depends on the propertiesmaxPollIntervalin ConsumerSettings
svroonland
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.