Make partitionPreFetchBufferLimit value 0 disable prefetching
#1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - add ConsumerSettings.withoutPartitionPreFetching - attempt to make test `a consumer timeout interrupts the stream and shuts down the consumer` stable by disabling prefetching
svroonland
reviewed
Oct 29, 2023
Also: remove parenthesis from `withoutPartitionPreFetching`
Also: correct docs about queueing and powers of 2
Also: make detection more performant by only fetching nano time once per run-loop
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you needed to use
ConsumerSettings.partitionPreFetchBufferLimit(1)to disable pre-fetching. I found that very confusing. After this change you can disable pre-fetching withConsumerSettings.partitionPreFetchBufferLimit(0), or simply withConsumerSettings.withoutPartitionPreFetching.Also: attempt to make test
a consumer timeout interrupts the stream and shuts down the consumerstable by disabling prefetching