Create Consumer and Producer from existing apache kafka Consumer/Producer #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
reviewed
Aug 7, 2023
| @@ -52,7 +51,13 @@ private[consumer] object ConsumerAccess { | |||
| ) | |||
| } | |||
| } { consumer => | |||
| ZIO.blocking(access.withPermit(ZIO.attempt(consumer.close(settings.closeTimeout)))).orDie | |||
| ZIO.blocking(ZIO.attempt(consumer.close(settings.closeTimeout))).orDie | |||
There was a problem hiding this comment.
Is this change safe? Isn't there a risk that .close is called in parallel with other Consumer methods?
There was a problem hiding this comment.
I don't see how unless it's explicitly leaked from the ZIO scope by the user
There was a problem hiding this comment.
Well I was wrong there. See #1238
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #452
Implements #694