Optimize Runloop::handleRequests code (#667)

zio · Feb 27, 2023 · 2b7c028 · 2b7c028
1 parent 2d1ddd1
commit 2b7c028
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/zio-kafka/src/main/scala/zio/kafka/consumer/internal/Runloop.scala b/zio-kafka/src/main/scala/zio/kafka/consumer/internal/Runloop.scala
@@ -493,12 +493,8 @@ private[consumer] final class Runloop(
       onFalse = consumer
         .withConsumer(_.assignment.asScala)
         .flatMap { assignment =>
-          ZIO.foldLeft(reqs)(state) { (state, req) =>
-            if (assignment.contains(req.tp))
-              ZIO.succeed(state.addRequest(req))
-            else
-              req.end.as(state)
-          }
+          val (toQueue, toEnd) = reqs.partition(req => assignment.contains(req.tp))
+          ZIO.foreach(toEnd)(_.end).as(state.addRequests(toQueue))
         }
         .orElseSucceed(state.addRequests(reqs))
     )