Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make types explicit in the transaction_record scope #968

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

zancas
Copy link
Member

@zancas zancas commented Apr 20, 2024

When I remove the use super::* (how did that sneak in?!)..

I get this cargo check result:

cargo check
warning: unused import: `orchard::note_encryption::OrchardDomain`
  --> zingolib/src/wallet.rs:10:5
   |
10 | use orchard::note_encryption::OrchardDomain;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `orchard::tree::MerkleHashOrchard`
  --> zingolib/src/wallet.rs:11:5
   |
11 | use orchard::tree::MerkleHashOrchard;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `sapling_crypto::note_encryption::SaplingDomain`
  --> zingolib/src/wallet.rs:14:5
   |
14 | use sapling_crypto::note_encryption::SaplingDomain;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `Vector`
  --> zingolib/src/wallet.rs:28:32
   |
28 | use zcash_encoding::{Optional, Vector};
   |                                ^^^^^^

warning: unused import: `zcash_note_encryption::Domain`
  --> zingolib/src/wallet.rs:29:5
   |
29 | use zcash_note_encryption::Domain;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `consensus::BlockHeight`
  --> zingolib/src/wallet.rs:31:24
   |
31 | use zcash_primitives::{consensus::BlockHeight, memo::Memo};
   |                        ^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `zingo_status::confirmation_status::ConfirmationStatus`
  --> zingolib/src/wallet.rs:33:5
   |
33 | use zingo_status::confirmation_status::ConfirmationStatus;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::wallet::notes::ShieldedNoteInterface`
  --> zingolib/src/wallet.rs:36:5
   |
36 | use crate::wallet::notes::ShieldedNoteInterface;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `COMMITMENT_TREE_LEVELS`
  --> zingolib/src/wallet.rs:40:32
   |
40 | use self::data::{WitnessTrees, COMMITMENT_TREE_LEVELS};
   |                                ^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::wallet::traits::ReadableWriteable`
  --> zingolib/src/wallet.rs:38:5
   |
38 | use crate::wallet::traits::ReadableWriteable;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: `zingolib` (lib) generated 10 warnings (run `cargo fix --lib -p zingolib` to apply 9 suggestions)

I suspect those were all "used" in that other scope just to support the use super::* in this scope!

@zancas zancas requested a review from AloeareV April 20, 2024 16:44
@zancas zancas requested review from Oscar-Pepper and removed request for AloeareV April 20, 2024 17:14
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicion!

@fluidvanadium fluidvanadium merged commit fe2fab2 into zingolabs:dev Apr 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants