Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note query #967

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Note query #967

merged 5 commits into from
Apr 21, 2024

Conversation

fluidvanadium
Copy link
Contributor

Adds a struct for querying notes properties.

zancas
zancas approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like OrchardNote isn't tested? Maybe I just missed it? It's not a blocker if it's missing we can add it.

zingolib/src/wallet/notes.rs Show resolved Hide resolved
@zancas zancas merged commit 316f163 into zingolabs:dev Apr 21, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@AloeareV AloeareV Awaiting requested review from AloeareV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluidvanadium @zancas