add comments #961
Merged
add comments #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oscar-Pepper
requested changes
Apr 19, 2024
zingolib/src/blaze/update_notes.rs
Outdated
| @@ -113,6 +113,7 @@ impl UpdateNotes { | |||
| .await | |||
| { | |||
| //info!("Note was spent, just add it as spent for TxId {}", txid); | |||
| // we got the height the nullifier was spent at. now, we go back to the index because todO actually we needed the CompactTx, not just the height | |||
There was a problem hiding this comment.
comment seems incomplete
There was a problem hiding this comment.
oops, these were unfinished! im so glad i got a chance to finish them
fluidvanadium
force-pushed
the
add_comments
branch
from
d6a915b
to
e126ddd
Compare
fluidvanadium
force-pushed
the
add_comments
branch
from
e126ddd
to
20c5373
Compare
zancas
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains some comments about BlockManagementData discovered this branch in one of my worktrees.
Contains descriptions of transactions.rs and its sub-modules.