Zip317 add propose command #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Oscar-Pepper
commented
Apr 10, 2024
Oscar-Pepper
commented
- Adds propose and quicksend commands
- Adds unimplemented do_propose and do_send_proposal lightclient methods
zancas
previously approved these changes
Apr 10, 2024
|
this looks good. the only conflict is the changelog. |
Closed
Closed
Oscar-Pepper
force-pushed
the
zip317_add_propose_command
branch
from
b35ff5c
to
dfb290b
Compare
zancas
requested changes
Apr 16, 2024
fluidvanadium
previously approved these changes
Apr 17, 2024
zancas
previously approved these changes
Apr 17, 2024
zancas
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.