extend test framework #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zancas
force-pushed
the
extend_test_framework
branch
from
c2baea8
to
3971de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run the tests when I have
pwdof zingolib/zingolib` that is, the crate root, I have to explicitly select the "test" feature like this:cargo nextest run --features testBUT if I run
cd $WORKSPACE_ROOT && cargo nextest runit run just fine and picks up the tests insidezingolib/zingolib.ChatGPT tells me that the
testfeature of the workspace member cratezingolib/zingolibis being picked up by "feature unification" in the workspace root.I don't like this.
cargo nextest runin the workspace root shouldn't be running all of our tests by accident.Debugging that feature unification issue might be interesting.. but.. if it's not borken...
The point of this PR is to build out some helpful things for writing MUCH NEEDED unit-tests.