Add transaction record map #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I stand by my original argument. This type is added to provided an implementer for a foreign trait. I vote we add this to dev, and I can hack on adding the functionality necessary to add the trait as a subsequent separate PR. |
This was referenced Apr 9, 2024
fluidvanadium
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fluidvanadium 's original hack was to add a native type that could have a foreign trait
zcash_client_backend::data_api::InputSourceimplemented on it.I've used a wrapper pattern with Deref and DerefMut implementations to all the "current" interface to be extended with the new interface (InputSource) while staying back compatible with the existing usage patterns.
This PR also pulls in the implementation of InputSource on TransactionRecordMap (I kept the same name as @fluidvanadium for the wrapper.)