Make addresses append only

[zancas]

No description provided.

[codecov-commenter]

Codecov Report

Patch coverage: 67.41% and project coverage change: -0.06% ⚠️

Comparison is base (5bb279f) 59.67% compared to head (be5695a) 59.62%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #430      +/-   ##
==========================================
- Coverage   59.67%   59.62%   -0.06%     
==========================================
  Files          34       34              
  Lines        5233     5221      -12     
==========================================
- Hits         3123     3113      -10     
+ Misses       2110     2108       -2     

Files Changed	Coverage Δ
zingocli/tests/integration_tests.rs	77.50% <ø> (ø)
zingolib/src/commands.rs	0.00% <0.00%> (ø)
zingolib/src/blaze/fetch_full_transaction.rs	77.97% <58.33%> (+0.12%)	⬆️
zingolib/src/wallet/keys/unified.rs	63.17% <61.11%> (-0.98%)	⬇️
zingolib/src/wallet.rs	63.14% <78.57%> (+0.02%)	⬆️
zingo-testutils/src/lib.rs	77.35% <100.00%> (-0.32%)	⬇️
zingolib/src/blaze/fetch_taddr_transactions.rs	89.36% <100.00%> (-0.44%)	⬇️
zingolib/src/blaze/trial_decryptions.rs	70.53% <100.00%> (+0.62%)	⬆️
zingolib/src/lightclient.rs	61.84% <100.00%> (-0.07%)	⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The merge-base changed after approval.

[AloeareV]

Awesome! Just a suggested loop tidying

[zancas]

I've converted this to draft on @fluidvanadium 's recommendation that we benchmark before merge.

[zancas]

I think this data, makes this PR no-longer-draft.

[AloeareV]

I think this data, makes this PR no-longer-draft.

Is there an easy way to compare this to dev benchmarks ran under the same circumstances?

[zancas]

This is the same benchmarks, run against the version of zingolib that's compiled into our last release.

[zancas]

@AloeareV

Here's the benchmark for the commit that was dev before this merged.