Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified cli keyloading #426

Merged
merged 3 commits into from
Aug 10, 2023
Merged

simplified cli keyloading #426

merged 3 commits into from
Aug 10, 2023

Conversation

fluidvanadium
Copy link
Contributor

No description provided.

AloeareV
AloeareV previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@fluidvanadium
Copy link
Contributor Author

Great!!

wait wait wait
can i do impl WalletBase { fn FromString
instead? wouldnt that be cleaner?

@AloeareV
Copy link
Contributor

AloeareV commented Aug 8, 2023

Great!!

wait wait wait can i do impl WalletBase { fn FromString instead? wouldnt that be cleaner?

You could do this, yes! It would be mildy cleaner, but yes, it would be cleaner!

@AloeareV
Copy link
Contributor

AloeareV commented Aug 8, 2023

Hang on...you could impl Parse for WalletBase, I think that would be even better

@zancas zancas merged commit c1938f0 into zingolabs:dev Aug 10, 2023
10 of 20 checks passed
@AloeareV AloeareV mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@AloeareV AloeareV AloeareV left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fluidvanadium @AloeareV @zancas