Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewkey only benchmark #411

Merged
merged 24 commits into from
Jul 12, 2023

Conversation

zancas
Copy link
Member

@zancas zancas commented Jul 11, 2023

  • reorganize LightClient impl blocks into constructors and other
  • alphabetize each impl block
  • remove integration_tests feature gate
  • unify test utils
  • export and use fvks for a client
  • rename ClientManager to ClientBuilder

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch coverage: 47.96% and project coverage change: +0.14 🎉

Comparison is base (991104e) 60.33% compared to head (e52cb9f) 60.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #411      +/-   ##
==========================================
+ Coverage   60.33%   60.48%   +0.14%     
==========================================
  Files          34       34              
  Lines        5252     5276      +24     
==========================================
+ Hits         3169     3191      +22     
- Misses       2083     2085       +2     
Impacted Files Coverage Δ
zingocli/tests/darkside/tests.rs 85.45% <ø> (ø)
zingolib/src/commands.rs 0.00% <ø> (ø)
zingolib/src/wallet/keys.rs 57.14% <ø> (ø)
zingolib/src/lightclient.rs 62.14% <36.31%> (-0.10%) ⬇️
zingo-testutils/src/lib.rs 86.80% <96.55%> (+0.95%) ⬆️
zingocli/tests/integration_tests.rs 84.84% <100.00%> (+1.24%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zancas zancas requested a review from Oscar-Pepper July 11, 2023 20:44
fluidvanadium
fluidvanadium previously approved these changes Jul 12, 2023
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@zancas zancas mentioned this pull request Jul 12, 2023
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good

@Oscar-Pepper Oscar-Pepper merged commit db77faf into zingolabs:dev Jul 12, 2023
@zancas zancas deleted the add_viewkey_only_benchmark branch September 27, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants