Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time rming instrumentation #406

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Time rming instrumentation #406

merged 3 commits into from
Jul 5, 2023

Conversation

zancas
Copy link
Member

@zancas zancas commented Jul 5, 2023

No description provided.

@zancas zancas requested a review from AloeareV July 5, 2023 21:19
AloeareV
AloeareV approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local benchmarks indicate that this about doubles the speed of sync compared to dev....I'm so glad we made these benchmarks. Would not have expected the added logging to interfere with sync to the level it did. Good that we caught it before release.

@AloeareV AloeareV merged commit 7185e8e into zingolabs:dev Jul 5, 2023
@zancas zancas deleted the time_rming_instrumentation branch September 27, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AloeareV AloeareV AloeareV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zancas @AloeareV