Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme and added birthday flag to examples #368

Merged

Conversation

Oscar-Pepper
Copy link
Contributor

is this still true now we have re-implemented the manual shielding button?

https://github.com/zingolabs/zingolib/blob/dev/README.md?plain=1#L19

i think this was a security risk maybe? where an attacker could dust a non-orchard pool and watch the note management automatically shield when the user sent funds?

"releases are currently only provisional" what does this mean? is this correct?
https://github.com/zingolabs/zingolib/blob/dev/README.md?plain=1#L6

@AloeareV
Copy link
Contributor

AloeareV commented Jun 6, 2023

is this still true now we have re-implemented the manual shielding button?

https://github.com/zingolabs/zingolib/blob/dev/README.md?plain=1#L19

It's still true for sapling, I think! It's no longer true for transparent.

i think this was a security risk maybe? where an attacker could dust a non-orchard pool and watch the note management automatically shield when the user sent funds?

You can still attempt to dust sapling and learn which transactions someone is sending if they don't shield first. It's no where near as leaky as it was when you could do the same with the transparent pool, but it's still a viable attack

"releases are currently only provisional" what does this mean? is this correct? https://github.com/zingolabs/zingolib/blob/dev/README.md?plain=1#L6

@Oscar-Pepper Oscar-Pepper marked this pull request as ready for review June 6, 2023 16:29
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (8e4fc70) 55.16% compared to head (bd512d0) 55.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #368   +/-   ##
=======================================
  Coverage   55.16%   55.16%           
=======================================
  Files          33       33           
  Lines        5232     5232           
=======================================
  Hits         2886     2886           
  Misses       2346     2346           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements!

@AloeareV AloeareV merged commit 6661a6c into zingolabs:dev Jun 7, 2023
@Oscar-Pepper Oscar-Pepper deleted the update_README_to_include_birthday_flag branch March 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants