Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed initial min_height from 0 to block height of first tx in summary #362

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

Oscar-Pepper
Copy link
Contributor

No description provided.

juanky201271
juanky201271 previously approved these changes Jun 2, 2023
Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to work.

Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (c9ecd50) 55.23% compared to head (68eaf08) 55.22%.

❗ Current head 68eaf08 differs from pull request most recent head d834ff5. Consider uploading reports for the commit d834ff5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #362      +/-   ##
==========================================
- Coverage   55.23%   55.22%   -0.02%     
==========================================
  Files          33       33              
  Lines        5221     5222       +1     
==========================================
  Hits         2884     2884              
- Misses       2337     2338       +1     
Impacted Files Coverage Δ
zingolib/src/lightclient.rs 60.12% <0.00%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Oscar-Pepper Oscar-Pepper merged commit 101f93c into zingolabs:dev Jun 2, 2023
@Oscar-Pepper Oscar-Pepper deleted the fix_get_birthday_command branch March 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants