Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic finsight transfer by address #344

Merged
merged 79 commits into from
May 18, 2023

Conversation

zancas
Copy link
Member

@zancas zancas commented May 16, 2023

No description provided.

@zancas zancas requested a review from AloeareV May 16, 2023 16:49
@zancas zancas mentioned this pull request May 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 53.09% and project coverage change: -0.29 ⚠️

Comparison is base (a7c1820) 55.66% compared to head (4f4fc3a) 55.38%.

❗ Current head 4f4fc3a differs from pull request most recent head ffc2cd3. Consider uploading reports for the commit ffc2cd3 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #344      +/-   ##
==========================================
- Coverage   55.66%   55.38%   -0.29%     
==========================================
  Files          32       33       +1     
  Lines        4982     5130     +148     
==========================================
+ Hits         2773     2841      +68     
- Misses       2209     2289      +80     
Impacted Files Coverage Δ
zingocli/src/lib.rs 0.00% <0.00%> (ø)
zingocli/tests/integration_tests.rs 80.88% <ø> (ø)
zingolib/src/blaze/test_utils.rs 27.27% <ø> (-6.07%) ⬇️
zingolib/src/commands.rs 0.00% <0.00%> (ø)
zingolib/src/lib.rs 40.00% <0.00%> (ø)
zingolib/src/wallet/traits.rs 51.25% <0.00%> (-0.83%) ⬇️
zingolib/src/wallet/transactions.rs 59.47% <14.28%> (+0.06%) ⬆️
zingolib/src/wallet.rs 63.44% <50.00%> (-0.03%) ⬇️
zingolib/src/wallet/data.rs 52.76% <50.00%> (-1.14%) ⬇️
zingolib/src/lightclient.rs 57.60% <56.80%> (-0.69%) ⬇️
... and 2 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AloeareV AloeareV marked this pull request as ready for review May 18, 2023 21:20
Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I've written the last half-dozen commits here, so I rule that another reviewer (@zancas is sufficient) is needed for merge.

@zancas zancas merged commit 48c4b4f into zingolabs:dev May 18, 2023
@zancas zancas deleted the basic_finsight_transfer_by_address branch September 27, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants