-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make example seed names more human friendly, and change imports #1487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zingolib/src/wallet/disk/testing/tests:
use crate::lightclient::LightClient;
use crate::wallet::disk::testing::examples::{MobileShuffleVersion, VillageTargetVersion};
use crate::wallet::keys::unified::UnifiedKeyStore;
use super::super::LightWallet;
use super::assert_wallet_capability_matches_seed;
use super::examples::NetworkSeedVersion;
use super::examples::{MainnetSeedVersion, RegtestSeedVersion, TestnetSeedVersion};
use super::examples::{
AbandonAbandonVersion, AbsurdAmountVersion, ChimneyBetterVersion, HospitalMuseumVersion,
HotelHumorVersion,
};
this is all over the place. while either paradigm is acceptable to me, it is essential that related items are grouped
okay, if we are going to require that style, can we do it all the way instead of leaving it halfway? im gonna do it now |
merged conflict in #1486 fixed use statements to consistently follow preferred style |
Oh.. sorry, I kicked off a sanity test and forgot to check it pre-push.. then noticed it was done and pushed. How's the current state? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if a file has import grouping, all imports should be grouped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
No description provided.