Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make example seed names more human friendly, and change imports #1487

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

zancas
Copy link
Member

@zancas zancas commented Oct 31, 2024

No description provided.

@zancas zancas requested a review from AloeareV October 31, 2024 00:32
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zingolib/src/wallet/disk/testing/tests:

use crate::lightclient::LightClient;
use crate::wallet::disk::testing::examples::{MobileShuffleVersion, VillageTargetVersion};
use crate::wallet::keys::unified::UnifiedKeyStore;

use super::super::LightWallet;
use super::assert_wallet_capability_matches_seed;

use super::examples::NetworkSeedVersion;

use super::examples::{MainnetSeedVersion, RegtestSeedVersion, TestnetSeedVersion};

use super::examples::{
    AbandonAbandonVersion, AbsurdAmountVersion, ChimneyBetterVersion, HospitalMuseumVersion,
    HotelHumorVersion,
};

this is all over the place. while either paradigm is acceptable to me, it is essential that related items are grouped

@fluidvanadium fluidvanadium self-requested a review October 31, 2024 17:10
@fluidvanadium
Copy link
Contributor

fluidvanadium commented Oct 31, 2024

okay, if we are going to require that style, can we do it all the way instead of leaving it halfway?

im gonna do it now

@fluidvanadium
Copy link
Contributor

merged conflict in #1486

fixed use statements to consistently follow preferred style

@zancas
Copy link
Member Author

zancas commented Oct 31, 2024

Oh.. sorry, I kicked off a sanity test and forgot to check it pre-push.. then noticed it was done and pushed. How's the current state?

Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a file has import grouping, all imports should be grouped

zingolib/src/wallet/disk/testing/tests.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@fluidvanadium fluidvanadium merged commit e96c48e into zingolabs:dev Nov 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants