Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring v16 dependency removed #1457

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Ring v16 dependency removed #1457

merged 2 commits into from
Oct 16, 2024

Conversation

juanky201271
Copy link
Contributor

@juanky201271 juanky201271 commented Oct 15, 2024 •
edited
Loading

Finally I removed ring v16 as a dependency from zingolib.
With this fix I can build zingo-pc for Windows arm64.

If this is correct I can close this PR: #1318

@juanky201271 juanky201271 self-assigned this Oct 15, 2024
zancas
zancas approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. I assume the sanity tests run and pass locally?

@nachog00 nachog00 merged commit 913c16c into zingolabs:dev Oct 16, 2024
17 checks passed
@juanky201271 juanky201271 mentioned this pull request Oct 16, 2024
Closed
@juanky201271 juanky201271 deleted the dev_removing_ring_v16_dependency branch October 16, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@AloeareV AloeareV Awaiting requested review from AloeareV

Assignees

@juanky201271 juanky201271

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanky201271 @zancas @nachog00