Multistep proposals #1443
Merged
Multistep proposals #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AloeareV
commented
Oct 7, 2024
zancas
reviewed
Oct 9, 2024
|
I would like to change the test to confirm that the receiver actually receives the funds sent to the tex. |
|
Running a local sanity check. |
AloeareV
force-pushed
the
multistep_proposals
branch
from
5644ab1
to
cfb7666
Compare
AloeareV
force-pushed
the
multistep_proposals
branch
from
98650c7
to
8436a45
Compare
zancas
force-pushed
the
multistep_proposals
branch
from
fa1d732
to
9d24079
Compare
…aps ephemeral_address, both made callable from more scopes handle the index equal to total keys case fix test errors update function name remove sanity check note that this doesn't handle upside down sync use wrapper add TODO, for removing transparent_child_ephemeral_addresses update parameter name wallet.blocks --> wallet.last_100_blocks update uniquely called fn parameter to reflect caller ident mysterious wtx --> prev_tx_record also look up ephemeral taddr transactions move taddr_set bind finish draft of helperization not a &mut on a Copy put the set of taddrs together assume we always care about all taddrs test code refactor texify comment start stubbing out tex detection fix whitespace and imports cthulhu hates trailing white space apply lints ready for sanity tests learn from clippy grab the tex address as a String clean up lints remove cascade of total_transparent_balue_spent working
AloeareV
force-pushed
the
multistep_proposals
branch
from
0f924f1
to
9f5a4cd
Compare
zancas
requested review from
dorianvp,
Oscar-Pepper and
fluidvanadium
and removed request for
dorianvp
…p_proposals_rebased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.