Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lrz update #1386

Merged
merged 36 commits into from
Sep 26, 2024
Merged

Lrz update #1386

merged 36 commits into from
Sep 26, 2024

Conversation

Oscar-Pepper
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper commented Sep 13, 2024

This is a PR that will merge when all fixes to LRZ update are complete and Cargo.toml is changed from main_zingolib branch to a final tag in zingolabs LRZ fork.

Please PR into this PR with each fix. full list of errors in cryptpad under "lrz update scrapbook"

UPDATE: this is ready to merge but blocked on backward compatibility tests for a change in USK derivation

Oscar-Pepper and others added 20 commits September 16, 2024 10:22
…sts_as_unimplemented' into lrz_update_fix_usk_issues
…_variant

add nu6 network variant as todo
fixed usk error and basic fixes to failing tests
@Oscar-Pepper Oscar-Pepper mentioned this pull request Sep 20, 2024
@zancas
Copy link
Member

zancas commented Sep 22, 2024

@Oscar-Pepper is this ready to merge into dev?

@Oscar-Pepper
Copy link
Contributor Author

@Oscar-Pepper is this ready to merge into dev?

no this is blocked on @fluidvanadium's backward-compatibility tests. #1413 I believe.

@zancas zancas marked this pull request as ready for review September 24, 2024 15:44
@zancas
Copy link
Member

zancas commented Sep 24, 2024

@fluidvanadium can you start by resolving conflicts? @Oscar-Pepper seemed to think this was ready to land, but I blocked on the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants