Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated secp256k1 and hdwallet #1365

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

fluidvanadium
Copy link
Contributor

No description provided.

@zancas
Copy link
Member

zancas commented Sep 9, 2024

Why are we pointing at master? Should we point at a specific immobile tag?

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@zancas
Copy link
Member

zancas commented Sep 9, 2024

Running tests locally..

@zancas
Copy link
Member

zancas commented Sep 9, 2024

CI fails on the guppy issue. I will try resetting the cargo lock file..

@zancas
Copy link
Member

zancas commented Sep 9, 2024

I reset the Cargo.lock to zingolabs/dev Cargo.lock and ran:

cargo check && cargo check --tests && cargo fmt && cargo clippy && ./utils/trailing-whitespace.sh reject

I have pushed the resulting code (lock file), to see if CI passes in this context.

@zancas zancas added the 320 label Sep 9, 2024
Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@juanky201271 juanky201271 merged commit 0650bc2 into zingolabs:dev Sep 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants