Zingo sync note commitments and retention #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go_sync_note_commitments_and_retention
…go_sync_note_commitments_and_retention
Closed
Oscar-Pepper
requested review from
zancas,
AloeareV,
fluidvanadium and
idky137
| .expect("only fvks currently supported"); | ||
| nullifiers_and_positions.insert(*output_id, (nullifier, position)); | ||
| }); | ||
| } | ||
|
|
||
| // TODO: unify sapling and orchard leaf and retention fns |
There was a problem hiding this comment.
this function is begging for a unit test. if it is possible to create example versions of these structs
fluidvanadium
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ontop of #1319