🛠️ Gizmos: Gizmos that don't use S3 shouldn't fail w/o AWS
#2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #709 We initialize `active-storage` and `aws-sdk-s3` when we load the application code, which loads up `config/storage.yml` and sets up an AWS S3 Client. But the `Journal` doesn't use AWS S3 (yet?), so the continuous integration environment doesn't have AWS credentials. Which causes [build failures]. I *could* add credentials to the Journal Gizmo's CI environment, but that would mean other Gizmos that don't use AWS S3 would need AWS credentials So I'm going to add some fake test credentials to the .env.test.example file, which should let the AWS S3 client initialize and then explode horribly when we try and shovel some data into it. [build failures]: https://github.com/zinc-collective/convene-journal/actions/runs/7690936384/job/20955491503
zspencer
added a commit
that referenced
this pull request
Jan 29, 2024
While working on zinc-collective#11, I completely forgot to run the tests locally. Embaressing, right? But I've grown overly used to codebases where running tests takes minutes-not-seconds; and there's not an easy way to "scope" the tests run to just the code that matters. Also I'm hacking while high, sue me! Anyway, people forget things... For reasons. And this time I forgot this, which exposed a hole in the safety-net in my weird multi-repo experiment. So I patched the hole in the bottom of the sea... sea: zinc-collective#12 Which uncovered a log in the hole in the bottom of the sea: #2160 So now I'm finishing the refactor and putting the frog on the log in the hole of the bottom of the sea, so that I can feed a gnat to the frog on the log in the hole of the bottom of the sea and implement the form fields to capture the `Entry#summary`
zspencer
added a commit
to zinc-collective/journal
that referenced
this pull request
Jan 29, 2024
While working on #11, I completely forgot to run the tests locally. Embaressing, right? But I've grown overly used to codebases where running tests takes minutes-not-seconds; and there's not an easy way to "scope" the tests run to just the code that matters. Also I'm hacking while high, sue me! Anyway, people forget things... For reasons. And this time I forgot this, which exposed a hole in the safety-net in my weird multi-repo experiment. So I patched the hole in the bottom of the sea... sea: #12 Which uncovered a log in the hole in the bottom of the sea: zinc-collective#2160 So now I'm finishing the refactor and putting the frog on the log in the hole of the bottom of the sea, so that I can feed a gnat to the frog on the log in the hole of the bottom of the sea and implement the form fields to capture the `Entry#summary`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gizmos#709We initialize
active-storageandaws-sdk-s3when we load the application code, which loads upconfig/storage.ymland sets up an AWS S3 Client.But the
Journaldoesn't use AWS S3 (yet?), so the continuous integration environment doesn't have AWS credentials. Which causes build failures.I could add credentials to the Journal Gizmo's CI environment, but that would mean other Gizmos that don't use AWS S3 would need AWS credentials
So I'm going to add some fake test credentials to the .env.test.example file, which should let the AWS S3 client initialize and then explode horribly when we try and shovel some data into it.