🥗🧹 Gizmo: System Spec to Add and Remove Gizmo
#1588
Conversation
zspencer
force-pushed
the
1565/write-system-test
branch
4 times, most recently
from
d344c03
to
c3c21dc
Compare
bin/setup
Outdated
| if test -f ".env.development"; then | ||
| echo "Found .env.development, leaving it in place!" | ||
| else | ||
| echo "Copying .env.development.example to .env.development" | ||
| cp .env.development.example .env | ||
| fi | ||
|
|
There was a problem hiding this comment.
I have a feeling the .devcontainer/startup.bash script may need to be updated with this new .env changes?
Specifically, the block starting at line 92 may need to be adjusted.
This assumption may be wrong, but I wanted to bring it up sooner rather than later.
There was a problem hiding this comment.
Great catch!!!
It would be nice if the three places we use (bin/setup, bin/setup-rails, and .devcontainer/startup.bash) all used the same shell script to create these default ffiles; perhaps bin/setup-env? Are you available to do that refactor?
There was a problem hiding this comment.
Sure, I can do that.
One script to do a conditionally copy of both .env.example and .env.development.example?
And then in the .devcontainer/startup.bash script, do the sed stuff after running this script?
Mostly just probing to make sure I'm understanding what needs to be here.
There was a problem hiding this comment.
Yep! I think the sed stuff should stay in the startup.bash
zspencer
force-pushed
the
1565/write-system-test
branch
from
bcf4e3a
to
871265f
Compare
.env.example
Outdated
| # SMTP_DOMAIN=localhost | ||
| # SMTP_AUTHENTICATION=plain | ||
| # SMTP_ADDRESS=localhost | ||
| # SMTP_ENABLE_TLS=false |
There was a problem hiding this comment.
Please break out system test step to it's own PR.
zspencer
force-pushed
the
1565/write-system-test
branch
from
a2272ee
to
df3ca07
Compare
zspencer
changed the base branch from
main
to
neighborhood/sprout-system-spec-setup
- #1565 For whatever reason the automated check doesn't *FAIL* despite it failing when we manually execute it! Add Firefox to the RSpec tests Run in Headless mode on CI Don't send real emails in CI save screenshots yo Add the .env.development to the devcontaine Add Firefox to the RSpec tests Run in Headless mode on CI Don't send real emails in CI save screenshots yo
- #1565 OK this is also a bit much; but it does fix the bug. I'm going to try and tighten it up a bit
zspencer
force-pushed
the
1565/write-system-test
branch
from
df3ca07
to
8706547
Compare
zspencer
added
🥗 test automation
zspencer
changed the title
Gizmo: System Spec to Add and Remove GizmoGizmo: System Spec to Add and Remove Gizmo
Gizmo's edit page does not actually remove theGizmofrom theSection#1565RoomtoSectionandFurnituretoGizmo#1472For some reason the automated check doesn't FAIL despite it failing when we manually execute it!
The "cause" is that the gizmo form has two
_methodfields, one is the hidden_methodfield that is automatically inserted byform_withwhen themodelispersisted?; the other is added by abuttonthat sets the_methodto delete so that it can be removed.In the system spec; the driven
firefoxtakes the_methodset by the clickedbutton. In the user-land; it sends both methods; and Rails picks the first one.The "solution" will be to ditch the second
_method(possibly even removing the ability to Remove a Gizmo from theupdateform.)