🛠️ Component: ButtonComponent supports GET Turbo Streams
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1187 - https://turbo.hotwired.dev/handbook/streams#streaming-from-http-responses It turns out that `Turbo` only does turbo-streams when `PUT`/`POST`/`DELETE` are the request methods. If we want to make `GET` requests use the `turbo-stream` request type, we need to specify it in the HTML output, i.e. `<a href="..." data-turbo-stream=true>` I wasn't sure if this should be default behavior or not, so I leaned towards making it default to not 🤷
anaulin
approved these changes
Apr 2, 2023
app/components/button_component.rb
Outdated
| @@ -8,7 +8,8 @@ def initialize( | |||
| method: :put, | |||
| confirm: nil, | |||
| disabled: false, | |||
| classes: nil | |||
| classes: nil, | |||
| turbo_stream: nil | |||
There was a problem hiding this comment.
Should this be false instead of nil? Doesn't make a functional difference right now, but feels more correct.
There was a problem hiding this comment.
false feels better for sure.
zspencer
added
🛠️ infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DesignLibrary#1187It turns out that
Turboonly does turbo-streams whenPUT/POST/DELETEare the request methods.If we want to make
GETrequests use theturbo-streamrequest type, we need to specify it in the HTML output, i.e.<a href="..." data-turbo-stream=true>I wasn't sure if this should be default behavior or not, so I leaned towards making it default to not 🤷