🧹 Furniture: Appease the Fuzz
#1211
Conversation
- #1209 (comment) - #709 I don't really like the direction this pushes specs, but I can live with it. In particular, a single assert per request/response seems... excruciatingly slow. But there are other mechanisms we can explore to mitigate that as it gets out of hand.
zspencer
force-pushed
the
furniture/rubocop-todos
branch
from
4e023c0
to
019226c
Compare
There was a problem hiding this comment.
Thank you!
I am also not fond of the "one assert per case" rule, and would be in favor of simply disabling it in our settings (which I know is a little bit against the whole point of using standard, but I think for Rspec-specific rules like this is justified).
|
I would be ecstatic if I can have my multi-expect it's again. |
|
I went to disable that particular cop and discovered that it is already disabled -- you disabled it 4 months ago: https://github.com/zinc-collective/convene/blame/main/.rubocop.yml#L19-L20 I reverted your commit locally and I didn't see any warnings for multiple expectations. 🤷🏼♀️ |
|
Yea, I think it was the "Number of Lines per Spec" cop... I just didn't read. |
Furniture: Complete the rename! #1209 (comment)Gizmos#709I don't really like the direction this pushes specs, but I can live with it.
In particular, a single assert per request/response seems... excruciatingly slow.
But there are other mechanisms we can explore to mitigate that as it gets out of hand.