Spaces: Support BYO Domains Everywhere! #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
added a commit
that referenced
this pull request
Dec 21, 2022
#74 This had been bugging me for a bit, where the paths on the page would always include the spaces, even if they were being routed to a custom domain. Now, we send folks to the domain that the space claims and drop the Space from the path, but only on urls built using Rails Polymorphic url builders. For example: `space_room_path(space, room)` will still go to `current_domain.example.com/spaces/:space_id/rooms/:room_id`, while `url_for([space, room])` or `link_to([space, room])` will go to `space_domain.example.com/rooms/:room_id` * Spaces: Support BYO Domains Everywhere! (#1001) Move (almost) everything to the Polymorphic syntax! * Provide slightly better docs and terser code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK so some work still to do here...