New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥔✨ `Space`: `Agreement`s #1364

Open

3 of 8 tasks

Tracked by

zspencer opened this issue Apr 15, 2023 · 0 comments

Open

3 of 8 tasks

Tracked by

🥔✨ `Space`: `Agreement`s #1364

zspencer opened this issue Apr 15, 2023 · 0 comments

Labels

🥔 Satisfices

Milestone

Member

zspencer commented Apr 15, 2023 •

edited

Loading

🥔⛰️ Space #1154

Spaces may have a Cookies Agreement, Privacy Agreement, Terms of Service, Content Policy, etc.

We don't currently offer a set of Terms of Service or a broader library, but we can at least let people put theirs in.

Use Cases

The text was updated successfully, but these errors were encountered:

zspencer added this to the 1.0 - Andromeda milestone

zspencer mentioned this issue

🥔⛰️ Space #1154

Open

12 tasks

zspencer added a commit that referenced this issue


          🥔 Agreement: They can be shown!

b74926a

 - #1364

This isn't the prettiest, but it'll do.

zspencer added a commit that referenced this issue


          🥔 Agreement: They can be shown!

176ae38

 - #1364

This isn't the prettiest, but it'll do.

zspencer added a commit that referenced this issue


          🥔 Agreement: They can be shown!

882ef64

 - #1364

This isn't the prettiest, but it'll do.

zspencer mentioned this issue

✨🥔 Agreement: They can be shown! #1365

Merged

zspencer changed the title ~~🌱 Spaces: Making and Keeping Agreements~~ 🌱 Spaces: Making Agreements

zspencer added a commit that referenced this issue


          ✨🥔 Agreements: Enumerate them in the Footer

7d4c1ee

- #1364

It just puts them in a little list, but with the p-4 there's a lot of
space. But it should be the right size for someone tapping on a phone I
hope?

zspencer mentioned this issue

✨🥔 Agreements: Enumerate them in the Footer #1366

Merged

zspencer changed the title ~~🌱 Spaces: Making Agreements~~ 🌱 Space: Agreements

zspencer added a commit that referenced this issue


          Agreements: List Agremeents on Space#edit

20a6735

- #1364

This doesn't link to the Agreements, but it gives me a hook to add in
the `#new`, `#edit` and `#destroy` bits in further PRs.

zspencer mentioned this issue

🥔✨ Agreements: List Agremeents on Space#edit #1367

Merged

zspencer added a commit that referenced this issue


          Agreements: List Agremeents on Space#edit

- #1364

This doesn't link to the Agreements, but it gives me a hook to add in
the `#new`, `#edit` and `#destroy` bits in further PRs.

zspencer added a commit that referenced this issue


          ✨🥔 Agreement: They can be shown! (#1365)

6ec234c

🥔 `Agreement`: They can be shown!

 - #1364

This isn't the prettiest, but it'll do.

zspencer added a commit that referenced this issue


          ✨🥔 Agreements: Enumerate them in the Footer (#1366)

c73053e

* ✨🥔 `Agreement`s: Enumerate them in the Footer

- #1364

It just puts them in a little list, but with the p-4 there's a lot of
space. But it should be the right size for someone tapping on a phone I
hope?

zspencer added a commit that referenced this issue


          Agreements: List Agremeents on Space#edit

459434e

- #1364

This doesn't link to the Agreements, but it gives me a hook to add in
the `#new`, `#edit` and `#destroy` bits in further PRs.

zspencer added a commit that referenced this issue


          🥔✨ Agreements: List Agreements on Space#edit (#1367)

163010e

- #1364

This doesn't link to the Agreements, but it gives me a hook to add in
the `#new`, `#edit` and `#destroy` bits in further PRs.

zspencer added a commit that referenced this issue


          Agreement: Test and implement the #create endpoint

c4753ae

- #1364

This is only for the classic HTML Request <=> Response Cycle. I realized
I probably want to do the `#index` Routes before `#create`, or at least
get started on the bits to expose adding an `Agreement` in the
`Spaces#edit` page.

zspencer mentioned this issue

🥗🥔✨ Agreements: can be created! #1374

Merged

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreement: Expose path to AgreementsController#new

9615a51

- #1364

This builds on the `Agreements#create` PR by exposing a UI for hitting
that endpoint via a Browser.

Note: I updated the footer because `space.agreements.new` creates an
un-persisted instance in the `space.agreements` collection.

zspencer added a commit that referenced this issue


          🥗✨ Agreement: Test and implement the #create endpoint

d168898

- #1364

This is only for the classic HTML Request <=> Response Cycle. I realized
I probably want to do the `#index` Routes before `#create`, or at least
get started on the bits to expose adding an `Agreement` in the
`Spaces#edit` page.

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreement: Expose path to AgreementsController#new

540b444

- #1364

This builds on the `Agreements#create` PR by exposing a UI for hitting
that endpoint via a Browser.

Note: I updated the footer because `space.agreements.new` creates an
un-persisted instance in the `space.agreements` collection.

zspencer mentioned this issue

🥗🥔✨ Agreement: Expose path to AgreementsController#new #1375

Merged

zspencer added a commit that referenced this issue


          🥗✨ Agreement: Test and implement the #create endpoint

dcad31b

- #1364

This is only for the classic HTML Request <=> Response Cycle. I realized
I probably want to do the `#index` Routes before `#create`, or at least
get started on the bits to expose adding an `Agreement` in the
`Spaces#edit` page.

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreement: Expose path to AgreementsController#new

260015e

- #1364

This builds on the `Agreements#create` PR by exposing a UI for hitting
that endpoint via a Browser.

Note: I updated the footer because `space.agreements.new` creates an
un-persisted instance in the `space.agreements` collection.

zspencer added a commit that referenced this issue


          🥗✨ Agreement: Test and implement the #create endpoint

f728636

- #1364

This is only for the classic HTML Request <=> Response Cycle. I realized
I probably want to do the `#index` Routes before `#create`, or at least
get started on the bits to expose adding an `Agreement` in the
`Spaces#edit` page.

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreement: Expose path to AgreementsController#new

305f27b

- #1364

This builds on the `Agreements#create` PR by exposing a UI for hitting
that endpoint via a Browser.

Note: I updated the footer because `space.agreements.new` creates an
un-persisted instance in the `space.agreements` collection.

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreement: Expose path to AgreementsController#new (#1375)

cd9ad43

- #1364

This builds on the `Agreements#create` PR by exposing a UI for hitting
that endpoint via a Browser.

Note: I updated the footer because `space.agreements.new` creates an
un-persisted instance in the `space.agreements` collection.

<img width="383" alt="Screenshot 2023-04-16 at 1 07 22 PM"
src="https://user-images.githubusercontent.com/50284/232339286-6b00afd0-4957-4853-81f9-ef65f90dafa9.png">
<img width="382" alt="Screenshot 2023-04-16 at 1 07 06 PM"
src="https://user-images.githubusercontent.com/50284/232339287-6792f77e-3499-42d2-836e-5632ecd110e3.png">
<img width="374" alt="Screenshot 2023-04-16 at 1 06 56 PM"
src="https://user-images.githubusercontent.com/50284/232339289-f908f140-49d1-40cc-857b-f9ded82ecdfa.png">
<img width="377" alt="Screenshot 2023-04-16 at 1 06 51 PM"
src="https://user-images.githubusercontent.com/50284/232339290-37517536-8412-4929-b0ad-707e56c6f708.png">

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: can be created! (#1374)

b69f41d

- #1364

This is only for the classic HTML Request <=> Response Cycle. I realized
I probably want to do the `#index` Routes before `#create`, or at least
get started on the bits to expose adding an `Agreement` in the
`Spaces#edit` page.

zspencer added a commit that referenced this issue


          🧹 Agreements: Add some quotes get rid of weird

613c387

- #1364

Some minor tidying from @anaulin's feedback and missing `'`

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Tea up the #update action

a35de99

- #1364

zspencer mentioned this issue

🥗🥔✨ Agreements: Tee up the #update action #1379

Merged

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Tea up the #update action

2f2a6cd

- #1364

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

c8c796e

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer mentioned this issue

🥗🥔✨ Agreements: Can be edited! #1380

Merged

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

38ca7cc

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

23e7dfd

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer added a commit that referenced this issue


          🥗🥔✨Agreements: Can be destroyed!

b9702e7

- #1364

zspencer added a commit that referenced this issue


          🧹 Agreements: Add some quotes get rid of weird

f5e6ae8

- #1364

Some minor tidying from @anaulin's feedback and missing `'`

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Tea up the #update action

7de89ac

- #1364

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

6d3209b

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer added a commit that referenced this issue


          🧹 Agreements: Add some quotes get rid of weird (#1377)

6993c66

- #1364

Some minor tidying from @anaulin's feedback and missing `'`

zspencer added a commit that referenced this issue


          🥗🥔✨Agreements: Can be destroyed!

c5590e0

- #1364

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Tea up the #update action

cc0f98d

- #1364

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

1723c9b

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

43a3498

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer added a commit that referenced this issue


          🥗🥔✨Agreements: Can be destroyed! (#1376)

daa9730

- #1364



### After
<img width="392" alt="Screenshot 2023-04-16 at 8 46 52 PM"
src="https://user-images.githubusercontent.com/50284/232373365-641d5a1b-1e95-4efb-b0c9-f42df829187b.png">
<img width="1728" alt="Screenshot 2023-04-16 at 8 46 41 PM"
src="https://user-images.githubusercontent.com/50284/232373369-ba03d821-05c8-4832-ba4e-93fcf0aef454.png">

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Implement the #update action (#1379)

251c73f

- #1364

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited!

9c37894

- #1364

A tiny step towards `#update`, but I think I am doing it backwards
because `#update` should work before we put in the `#edit` form

zspencer added a commit that referenced this issue


          🥗🥔✨ Agreements: Can be edited! (#1380)

eac32f0

- #1364


### After 
<img width="411" alt="Screenshot 2023-04-16 at 9 41 45 PM"
src="https://user-images.githubusercontent.com/50284/232379864-b0fbb15f-7da0-4ee9-aa4e-97c1964b888f.png">
<img width="390" alt="Screenshot 2023-04-16 at 9 41 41 PM"
src="https://user-images.githubusercontent.com/50284/232379868-9cdd9efe-0f97-4b7d-8db6-2148e86143b9.png">
<img width="385" alt="Screenshot 2023-04-16 at 9 40 15 PM"
src="https://user-images.githubusercontent.com/50284/232379873-416d9fe3-f31a-4d10-8ac9-6f1906de0bbc.png">

zspencer changed the title ~~🌱 Space: Agreements~~ 🥔 Space: Agreements

zspencer added the 🥔 Satisfices label

zspencer modified the milestones: 1.0 - Andromeda, 1.1 - Andromeda I

zspencer mentioned this issue

🌸 Spaces: Prevent "Add Agreement" button from overlapping #1461

Merged

zspencer changed the title ~~🥔 Space: Agreements~~ 🥔✨ Space: Agreements

zspencer added a commit that referenced this issue


          🌸 Space: De-italicize help-text on Space edit

6d6b18d

- #1364
- #252
- #1513

Remove Moar italics! MOAR!

zspencer mentioned this issue

🌸 Space: De-italicize help-text on Space#edit #2223

Merged

zspencer added a commit that referenced this issue


          🌸 Space: De-italicize help-text on Space#edit (#2223)

bd4a37e

- #1364
- #252
- #1513

Remove Moar italics! MOAR!

zspencer added a commit to zinc-collective/tobias that referenced this issue


          🌸 Space: De-italicize help-text on Space#edit (zinc-collective#2223)

5cb17b8

- zinc-collective#1364
- zinc-collective#252
- zinc-collective#1513

Remove Moar italics! MOAR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment