🧹 Node 16 has reached End-of-Life! Long Live Node 18! (#1879)

- #892

Per https://github.com/nodejs/release#release-schedule, Node 16 is
decommissioned! This bumps us to the newest LTS, Node 18! Hooray!

Make sure to delete your `node_modules` folder, since I have no idea how
any of this works but I expect that keeping old node modules around is
bad-idea-jeans.

.env.example

@@ -21,7 +21,7 @@
 
 PORT=3000
 # Used to build URLs in mailers
-APP_ROOT_URL=http://localhost:3000
+APP_ROOT_URL=http://127.0.0.1:3000
 EMAIL_DEFAULT_FROM='Neighborhood Support <[email protected]>'
 
 # Ensures the data in our database is fully encrypted

.github/workflows/test-convene-web.yml

@@ -48,7 +48,7 @@ jobs:
       - name: Setup Node with cache
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - name: Install Node dependencies
@@ -109,7 +109,7 @@ jobs:
       - name: Setup Node with cache
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - name: Allow Ruby process to access port 80
@@ -177,7 +177,7 @@ jobs:
       - name: Setup Node with cache
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - name: Install Firefox
@@ -212,7 +212,7 @@ jobs:
         run: |
           # To wait for asset built
           # TODO: Start server in production mode
-          curl --connect-timeout 5 --retry 5 --retry-delay 5 --retry-max-time 40 --retry-connrefused localhost:3000 1> /dev/null
+          curl --connect-timeout 5 --retry 5 --retry-delay 5 --retry-max-time 60 --retry-connrefused localhost:3000 1> /dev/null
           yarn run test
       - name: Upload Test Results
         uses: actions/upload-artifact@v2
@@ -238,7 +238,7 @@ jobs:
       - name: Setup Node with cache
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: 'yarn'
 
       - name: Install Node dependencies

.nvmrc

@@ -1 +1 @@
-16.20.1
+18.18.0

config/puma.rb

@@ -10,7 +10,8 @@
 
 # Specifies the `port` that Puma will listen on to receive requests; default is 3000.
 #
-port ENV.fetch("PORT", 3000)
+# port ENV.fetch("PORT", 3000)
+bind "tcp://0.0.0.0:#{ENV.fetch("PORT", 3000)}"
 
 # Specifies the `environment` that Puma will run in.
 #

features/lib/MailServer.js

@@ -36,7 +36,7 @@ class MailServer {
    */
   emails() {
     return axios
-      .get("http://localhost:1080/email")
+      .get("http://127.0.0.1:1080/email")
       .then((res) => res.data)
       .catch((err) => console.log(err));
   }

features/lib/appUrl.js

@@ -1,5 +1,5 @@
 export default (function () {
   return process.env.APP_ROOT_URL
     ? process.env.APP_ROOT_URL
-    : "http://localhost:3000";
+    : "http://127.0.0.1:3000";
 });

package.json

@@ -5,7 +5,7 @@
   "exports": "./index.js",
   "type": "module",
   "engines": {
-    "node": "^16.13",
+    "node": "^18.8",
     "yarn": "^1.22"
   },
   "scripts": {