Missing imports with React 15.4.0

[stevewillard]

It looks like this plugin uses some React internals which got shifted around in 15.4.0

ERROR in ./~/react-tap-event-plugin/src/injectTapEventPlugin.js
Module not found: Error: Can't resolve 'react/lib/EventPluginHub' in '/Users/me/Documents/github/project/node_modules/react-tap-event-plugin/src'
 @ ./~/react-tap-event-plugin/src/injectTapEventPlugin.js 23:2-37
 @ ./src/app/entry.js
 @ multi app

[alexborisov]

https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html

However, there is a possibility that you imported private APIs from react/lib/*, or that a package you rely on might use them. We would like to remind you that this was never supported, and that your apps should not rely on internal APIs. The React internals will keep changing as we work to make React better.

This is exactly the case. Also now react-router seems to also be broken because it's depending on react/lib/ReactMount

[twhitbeck]

I'm seeing all these react/lib/* modules in react-dom/lib now, however simply switching them over to that makes onTouchTap not work :/

[brendanmh]

Did this issue start appearing today? I have just noticed it too, with react 15.2.1 and react-tap-event-plugin 1.0.0 with no apparent change in my code.

Edit - I am pulling in react 15.4.0

[petersendidit]

Pull request #82 will fix this issue for React 15.4.0

[stevewillard]

@brendanmh yeah 15.4.0 was released today

[aclarkdev]

i'm having this same issue with react ^15.3.0 and react-tap-event-plug ^1.0.0

[mamachanko]

same here with

{
...
    "react-tap-event-plugin": "1.0.0",
    "react": "15.4.0",
...
}

[aclarkdev]

i recommend rolling back until fix... i went back to
"react": "15.3.0", "react-dom": "15.2.1", "react-redux": "4.4.5",

and everything works again

[s0meone]

There was some other issue besides the missing imports, this now fixed. Version 2.0.0 is now on npm and is compatible with React 15.4. Thanks for reporting!

[sfncook]

Seems like material-ui is still stuck on react-tap-event 1.0.0 :(

[danmo]

What harm can a tiny deploy to production do ? right ? :) 💣

[ghost]

We haven't changed our package.json (requirements) for quite some time. All versions are fix (see below). We deploy everyday. How can this happen now?

"dependencies": {
    "babel": "^5.6.23",
    "babel-core": "^6.14.0",
    "babel-loader": "^6.2.5",
    "babel-plugin-add-module-exports": "^0.2.1",
    "babel-plugin-react-html-attrs": "^2.0.0",
    "babel-plugin-transform-class-properties": "^6.11.5",
    "babel-plugin-transform-decorators-legacy": "^1.3.4",
    "babel-preset-es2015": "^6.14",
    "babel-preset-react": "^6.11.1",
    "babel-preset-stage-0": "^6.5.0",
    "css-loader": "^0.25.0",
    "es6-promise": "^3.0.2",
    "giphy-api": "^1.2.1",
    "immutable": "^3.8.1",
    "inherits": "^2.0.3",
    "less": "^2.7.1",
    "less-loader": "^2.2.3",
    "material-ui": "^0.16.1",
    "minimatch": "^3.0.3",
    "moment": "^2.15.1",
    "pui-react-overlay-trigger": "^6.0.2",
    "pui-react-tooltip": "^6.0.2",
    "react": "^15.3.2",
    "react-addons-css-transition-group": "^15.3.2",
    "react-dom": "^15.3.2",
    "react-redux": "^4.4.5",
    "react-tap-event-plugin": "^1.0.0",
    "react-timeout": "^1.0.0",
    "redux": "^3.6.0",
    "redux-logger": "^2.6.1",
    "redux-promise": "^0.5.3",
    "redux-thunk": "^2.1.0",
    "style-loader": "^0.13.1",
    "webpack": "^1.13.2",
    "whatwg-fetch": "^1.0.0"
  },

[brendanmh]

"react": "^15.3.2", means that you can install any [email protected] version, which includes [email protected] which is causing the trouble.

You can try "react": "15.3.2", or "react": "~15.3.2",. However you will probably find that other modules will pull in [email protected] too (like material-ui), so you will have to amend them.

[ghost]

Sorry for spamming the thread.
thx @brendanmh. I assumed "^X.Y.Z" is a regex ..

[lucasconstantino]

Well, not wanting to flood here but you guys should have a look at https://yarnpkg.com/. It would most certainly avoid breaks on production.

[wingleungchoi]

Mates, I got familiar errors.

Unable to resolve some modules:

  "react/lib/EventPluginHub" in /Users/xxxxx/xxxx/xxx/node_modules/react-tap-event-plugin/src/injectTapEventPlugin.js (web.browser)
  "react/lib/EventConstants" in /Users/xxxxx/xxxx/xxx/node_modules/react-tap-event-plugin/src/TapEventPlugin.js (web.browser)
  "react/lib/EventPluginUtils" in /Users/xxxxx/xxxx/xxx/node_modules/react-tap-event-plugin/src/TapEventPlugin.js (web.browser)
  "react/lib/EventPropagators" in /Users/xxxxx/xxxx/xxx/node_modules/react-tap-event-plugin/src/TapEventPlugin.js (web.browser)
  "react/lib/SyntheticUIEvent" in /Users/xxxxx/xxxx/xxx/node_modules/react-tap-event-plugin/src/TapEventPlugin.js (web.browser)
  "react/lib/ViewportMetrics" in /Users/xxxxx/xxxx/xxx/node_modules/react-tap-event-plugin/src/TapEventPlugin.js (web.browser)

My environment was

├─┬ [email protected]
│ ├─┬ [email protected]
│ │ ├── [email protected]
│ │ ├─┬ [email protected]
│ │ │ ├─┬ [email protected]
│ │ │ │ ├─┬ [email protected]
│ │ │ │ │ └── [email protected]
│ │ │ │ └── [email protected]
│ │ │ └── [email protected]
│ │ ├─┬ [email protected]
│ │ │ └── [email protected]
│ │ └── [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ └── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ └── [email protected]
├── [email protected]
├─┬ [email protected]
│ └── [email protected]
├── [email protected]
├─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]

When i rollback react to 15.0.1, it works

[mrdulin]

@aclarkdev thanks.

[sfncook]

@wingleungchoi You need to upgrade to [email protected] I think there are newer versions of react too.

[lucasmonteiro001]

@aclarkdev your suggestion did solved my problem! Thx a lot! 👍

[asidiali]

Updating to v2.0.0 of react-tap-event-plugin fixed this for me. I had to manually update my package file as it wasn't detecting an update via CLI for some reason.

[thomasmodeneis]

Oh this is just embarrassing, really.

[calbertts]

I don't understand why this pluging still exists, most of the time it's the reason for wasted time.