Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IVF_FLAT backward compatible when cosine #93

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Sep 19, 2023

Issue: #30

In latest IVF_FLAT index, there is a byte to indicate whether the metric type is COSINE in the index header; while the byte indicator not exist in the IVF_FLAT_NM index header.
So when read IVF_FLAT_NM format, knowhere uses the input config json to tell it's COSINE or not, then convert IVF_FLAT_NM format to the new IVF_FLAT format.

@mergify
Copy link

mergify bot commented Sep 19, 2023

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 19, 2023

/kind enhancement

src/index/ivf/ivf.cc Outdated Show resolved Hide resolved
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cydrain cydrain force-pushed the caiyd_fix_ivfflat_cosine branch 2 times, most recently from 1dc4a8a to d5f9a23 Compare September 20, 2023 01:50
@mergify mergify bot added the ci-passed label Sep 20, 2023
@cydrain
Copy link
Collaborator Author

cydrain commented Sep 20, 2023

/hold

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 20, 2023

/unhold

@cydrain cydrain force-pushed the caiyd_fix_ivfflat_cosine branch from beeb063 to c214da4 Compare September 20, 2023 10:51
@zhengbuqian
Copy link
Collaborator

/lgtm

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 21, 2023

/run-e2e

1 similar comment
@liliu-z
Copy link
Collaborator

liliu-z commented Sep 21, 2023

/run-e2e

@liliu-z liliu-z merged commit 0dfc03b into zilliztech:main Sep 21, 2023
7 checks passed
@cydrain cydrain deleted the caiyd_fix_ivfflat_cosine branch September 22, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants