-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IVF_FLAT backward compatible when cosine #93
Conversation
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
/kind enhancement |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain, Presburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1dc4a8a
to
d5f9a23
Compare
/hold |
/unhold |
d5f9a23
to
beeb063
Compare
Signed-off-by: Yudong Cai <[email protected]>
beeb063
to
c214da4
Compare
/lgtm |
/run-e2e |
1 similar comment
/run-e2e |
Issue: #30
In latest IVF_FLAT index, there is a byte to indicate whether the metric type is COSINE in the index header; while the byte indicator not exist in the IVF_FLAT_NM index header.
So when read IVF_FLAT_NM format, knowhere uses the input config json to tell it's COSINE or not, then convert IVF_FLAT_NM format to the new IVF_FLAT format.