-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: provide a static checking method for index config #888
Conversation
/hold |
@foxspy 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=========================================
+ Coverage 0 79.52% +79.52%
=========================================
Files 0 81 +81
Lines 0 6256 +6256
=========================================
+ Hits 0 4975 +4975
- Misses 0 1281 +1281 |
f549054
to
1aa6181
Compare
Signed-off-by: xianliang.li <[email protected]>
Signed-off-by: xianliang.li <[email protected]>
1aa6181
to
e9c47fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/kind improvement |
@@ -501,6 +501,7 @@ const float defaultRangeFilter = 1.0f / 0.0; | |||
|
|||
class BaseConfig : public Config { | |||
public: | |||
CFG_INT dim; // just used for config verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dim could be larger than the int32 max for sparse. should use a larger type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently sparse dim range is uint32max
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently sparse dim range is uint32max
Plz create an issue to track
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatted offline, fixed in #903
issue: #795
based on: #887