Write old format IVF_FLAT index for backward compatible #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
/kind enhancement |
liliu-z
reviewed
Sep 22, 2023
cydrain
force-pushed
the
caiyd_ivf_flat_backward_compatible
branch
from
e578e38
to
82607d5
Compare
foxspy
reviewed
Sep 24, 2023
cydrain
force-pushed
the
caiyd_ivf_flat_backward_compatible
branch
from
82607d5
to
3b99047
Compare
|
/run-e2e |
cydrain
force-pushed
the
caiyd_ivf_flat_backward_compatible
branch
2 times, most recently
from
989a164
to
4800613
Compare
Signed-off-by: Yudong Cai <[email protected]>
cydrain
force-pushed
the
caiyd_ivf_flat_backward_compatible
branch
from
4800613
to
c42a5b3
Compare
foxspy
approved these changes
Sep 26, 2023
| } // namespace | ||
|
|
||
| class Version { | ||
| public: | ||
| explicit Version(const IndexVersion& version) : version_(version) { | ||
| explicit Version(const IndexVersion version) : version_(version) { |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
This was referenced Dec 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #30