Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replica support #160

Merged
merged 3 commits into from
Dec 24, 2022
Merged

Add replica support #160

merged 3 commits into from
Dec 24, 2022

Conversation

shanghaikid
Copy link
Collaborator

@shanghaikid shanghaikid commented Dec 23, 2022 •
edited
Loading

  • move load/release dialog to separate dialog
  • add replica logic
  • adjust some styling
    image
    image
    image
    image

@shanghaikid
Copy link
Collaborator Author

this pr resolve #95 #102

@shanghaikid shanghaikid marked this pull request as ready for review December 23, 2022 08:29
Tumao727
Tumao727 reviewed Dec 23, 2022
View reviewed changes
client/src/components/dialogs/ReleaseCollectionDialog.tsx Outdated
// release collection
await CollectionHttp.releaseCollection(collection);
// enable confirm button
setDisabled(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if releaseCollection failed, always disable button?

@shanghaikid shanghaikid merged commit 10a1a58 into main Dec 24, 2022
@shanghaikid shanghaikid deleted the add-replica branch December 24, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tumao727 Tumao727 Tumao727 approved these changes

@nameczz nameczz Awaiting requested review from nameczz

Assignees
No one assigned
Labels
ready_to_release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanghaikid @Tumao727