Support for pgdiskann client #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @alwayslove2013 |
greenhal
reviewed
Oct 28, 2024
Comment on lines
+60
to
+61
| "This will set the parameters: max_parallel_maintenance_workers," | ||
| " max_parallel_workers & table(parallel_workers)", |
There was a problem hiding this comment.
These help text lines (60-61) belong with "--max-parallel-workers", this is also an issue an issue with the pgvectory cli.py.
alwayslove2013
approved these changes
Oct 29, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, wahajali The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for pgdiskann - a recent postgres extension that adds support for DiskANN index type to postgres. Following pgdiskann specific parameters are configurable for pgdiskann:
l_value_is
l_value_ib
max_neighbors
Note
The pgdiskann extension is currently in private preview on Azure PostgreSQL and requires special permission to access. For more details, see the preview announcement and fill out this form to request access.