Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgvecto.rs: upgrade pgvecto.rs sdk to v0.2.2 #373

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

cutecutecat
Copy link
Contributor

@cutecutecat cutecutecat commented Oct 8, 2024

Here we introduce a bug fix for PGVecto.rs >= 0.4.0

If we don't need quantization, we pick a trivial option at WebUI, and this is the default behavior.

In pgvecto.rs sdk = 0.2.1, it will be translated into [indexing.ivf.quantization.trivial] or [indexing.hnsw.quantization.trivial] as toml config.

https://github.com/tensorchord/pgvecto.rs-py/blob/5e175a981b36fbb671033c2db45636a11d6dc04f/tests/__init__.py#L108

But we have a breaking change in PGVecto.rs 0.4.0, that it would not accept trivial quantization config. To express no quantization, quantization should not be showed in config.

So pgvecto.rs sdk = 0.2.2 change the behavior that will translate trivial option into [indexing.ivf] or [indexing.hnsw].

https://github.com/tensorchord/pgvecto.rs-py/blob/5bc6fc34f2d0df05701000f298596587d58acc99/tests/__init__.py#L108

This is a transparent compile inside SDK, and forward compatibility, so there is nothing to do for VectorDBBench except a upgrade.

@cutecutecat cutecutecat changed the title feat: upgrade pgvecto.rs sdk to v0.2.2 pgvecto.rs: upgrade pgvecto.rs sdk to v0.2.2 Oct 8, 2024
@cutecutecat cutecutecat marked this pull request as ready for review October 8, 2024 02:22
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, cutecutecat
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 merged commit 51b1ece into zilliztech:main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants