-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow sessions to file. fixes #2001, #2186 and refs #3454 #3522
Conversation
craigh
commented
Apr 5, 2017
•
edited
Loading
edited
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Fixed tickets | fixes #2001, #2186 |
Refs tickets | #3454 |
License | MIT |
Changelog updated | yes |
hmm - a problem with the CLI invalid csrf ... 🤔 😠 @matthiasnoback - do you know why symfony-console-form is using the tokens? I thought it would ignore them? see https://travis-ci.org/zikula/core/builds/219052481 |
well I came up with a sort of hacky fix to the csrf problem when using cli. |
src/docs/Core-2.0/Session.md
Outdated
=================== | ||
|
||
Sessions can be stored in the Database or in the Filesystem. This choice as well as a few configuration options | ||
can be set in the ZikulaSecurityModule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. How about Zikula SecurityCenter module
?
$request->getSession()->getFlashBag()->add('info', $this->__f( | ||
'Session are currently configured to use the filesystem. It is recommended that you change this to use the database. Click %here% to configure.', | ||
['%here%' => '<a href="' . $router->generate('zikulasecuritycentermodule_config_config') . '">' . $this->__('Security Center') . '</a>'] | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to change it to the database automatically during/after the CompleteStage
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it forces a re-login, so I didn't think that was the best method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Added some minor comments.
@craigh Indeed, I thought the |
@matthiasnoback - we are using an older version of your library with this branch - could that be the cause? Was there anything special with the form classes I was to do? |
@craigh Honestly, don't know. |
@matthiasnoback looks like I just needed to update the library. I was using an older version (v1) because this branch originally was restricted to php >= 5.4, but now it is updated to require php >=5.5 and so I can use v2 of the lib and this fixes the problem. |